Open
Conversation
Fumuran
added
the
no changelog
mmagician
added
agglayer
mmagician
reviewed
Mar 2, 2026
Collaborator
mmagician
left a comment
mmagician
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Unfortunately I think this is one of those bike-sheddeable PRs, so let me go right at it 😁
There are some slots in bridge_config.masm, of which I think one deserves a rename (of the last component - I'd drop miden prefix from all of them as outlined in the other comments above):
const GER_STORAGE_SLOT=word("miden::agglayer::bridge::ger")
I'd change the name to indicate it's a map.
Regarding admin / ger_manager - we might want to be consistent w.r.t. this holding an account ID, similarly to bridge_id.
So maybe admin_id etc.? Alternatively, suffix all of them with _account_id instead for extra clarity.
| # Storage slots | ||
| # The slot in this component's storage layout where the bridge account ID is stored. | ||
| const BRIDGE_ID_SLOT = word("miden::agglayer::faucet") | ||
| const BRIDGE_ID_SLOT = word("miden::agglayer::bridge::id") |
Collaborator
There was a problem hiding this comment.
as per the docs, we should follow:
project_name::component_name::slot_name
Here, I would make two modifications:
- drop
midenaltogether (from all agglayer storage slots) - use
bridgeorfaucetdepending on which component this belongs to (e.g. particular one belongs to the faucet, but describes the bridge account ID. So overall I'd keep it asagglayer::faucet::bridge_id)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tiny PR updates some of the storage slot names, namely:
miden::agglayer::letandmiden::agglayer::let::*were renamed to have additionalbridgeafteragglayer:miden::agglayer::bridge::letto make all bridge related storage slot consistently havebridgein their names.miden::agglayer::faucetandmiden::agglayer::faucet::conversion_info_{1, 2}storage slots were renamed tomiden::agglayer::bridge::idandmiden::agglayer::bridge::conversion_info_{1, 2}. While being the storage slots of the faucet, these slots store the bridge data, so the new name should represent the contents more clearly.Closes: #2356